Open
Conversation
Contributor
|
Thanks for looking in to #3. Would you mind adding a test for this? Did you try your fixes out on the initial problem? I am looking for people to help maintain this ;) |
Contributor
Author
|
Here we go. I could not find the test app mentioned in #3, but my applications had the same problem, which is solved with this change. |
Contributor
|
Tests are failing on this branch. If you can merge master, keep keywords on Link and have tests pass, I can pull this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A basic solution for issue #3 - simply process any DELETE requests only after all other requests in the queue have been processed.